Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2,src: remove duplicate words in comments #17939

Closed
wants to merge 2 commits into from
Closed

http2,src: remove duplicate words in comments #17939

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jan 1, 2018

Again found using a regex.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, src

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 1, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 1, 2018
@tniessen
Copy link
Member Author

tniessen commented Jan 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/66/

@tniessen
Copy link
Member Author

tniessen commented Jan 1, 2018

Landed in 93acfe5, 47ee340.

@tniessen tniessen closed this Jan 1, 2018
tniessen added a commit that referenced this pull request Jan 1, 2018
@tniessen
src: remove duplicate words in comments
93acfe5 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
tniessen added a commit that referenced this pull request Jan 1, 2018
@tniessen
http2: remove duplicate words in comments
47ee340 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
@tniessen @MylesBorins
http2: remove duplicate words in comments
8d8dfea 
PR-URL: nodejs#17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@tniessen @MylesBorins
http2: remove duplicate words in comments
27c11c1 
Backport-PR-URL: #18050
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@tniessen @MylesBorins
src: remove duplicate words in comments
6ad25d9 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@tniessen @MylesBorins
http2: remove duplicate words in comments
a003ded 
Backport-PR-URL: #18050
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@tniessen @MylesBorins
src: remove duplicate words in comments
aa75190 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

should be included in a larger http2 update

MylesBorins pushed a commit that referenced this pull request May 22, 2018
@tniessen @MylesBorins
src: remove duplicate words in comments
14f29e3 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@tniessen @MylesBorins
http2: remove duplicate words in comments
b046412 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@tniessen @MylesBorins
src: remove duplicate words in comments
1f8b831 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@tniessen @MylesBorins
http2: remove duplicate words in comments
f8efa8e 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@tniessen @rvagg
src: remove duplicate words in comments
2c6f482 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@tniessen @rvagg
http2: remove duplicate words in comments
06329a8 
PR-URL: #17939
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @MylesBorins @jasnell @cjihrig @maclover7 @nodejs-github-bot